Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-5062 fix: switch to using descendent roles instead of actions #1546

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

rtitle
Copy link
Contributor

@rtitle rtitle commented Sep 23, 2024

Ticket: https://broadworkbench.atlassian.net/browse/IA-5062

What:

#1543 added the leo_migration resource access policies to Sam. We think it was generating a lot of inserts by using descendent actions instead of roles, which was causing issues in Sam dev. Switching to roles to be more performant.

Why:

<For your reviewers' sake, please describe in ~1 paragraph what the value of this PR is to our users or to ourselves.>

How:

<For your reviewers' sake, please describe in ~1 paragraph how this PR accomplishes its goal.>

<If the PR is big, please indicate where a reviewer should start reading it (i.e. which file or function).>


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

src/main/resources/reference.conf Outdated Show resolved Hide resolved
Copy link

@rtitle rtitle requested a review from tlangs September 23, 2024 16:03
@rtitle rtitle merged commit c6340c0 into develop Sep 23, 2024
25 checks passed
@rtitle rtitle deleted the rt-ia-5062-fix branch September 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants