Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-400] #major pre-releases use -snapshot suffix #1532

Closed
wants to merge 1 commit into from

Conversation

okotsopoulos
Copy link
Contributor

Ticket: https://broadworkbench.atlassian.net/browse/DCJ-400

What:

Sam clients published as part of commits to PRs will now be suffixed with -snapshot rather than -SNAP.

Why:

Many Terra services use Dependabot to automate dependency upgrades. Dependabot will ignore new versions with -snapshot suffix and rightfully interpret them as prereleases. https://github.com/dependabot/dependabot-core/blob/8f9e4734020e0029a9ec53e1d38163bbcc6235c7/gradle/lib/dependabot/gradle/version.rb#L25

Also tagging this as a major release to bring Sam client versions up to 1.0.0, past older versions pre-semver. My earlier attempt to do so did not properly trigger client publication on account of being a no-code commit: #1527

How:

Updated client version suffix in codegen directories.


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

Such as the client builds generated as part of PR commits.

Many Terra services use Dependabot to automate dependency upgrades.
Dependabot will ignore new versions with `-snapshot` suffix and rightfully interpret them as prereleases.

Also tagging this as a major release to bring Sam client versions up to 1.0.0, past older versions pre-semver.  My earlier attempt to do so did not properly trigger client publication on account of being a no-code commit.
Copy link

sonarqubecloud bot commented Sep 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant