ID-1353 Support Favorite Resources in Sam #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // when(samRoutes.requireAnyAction(ArgumentMatchers.eq(resource), ArgumentMatchers.eq(user.id), any[SamRequestContext])) | ||
| // .thenReturn(Directives.mapInnerRoute { innerRoute => onSuccess(IO.unit) { innerRoute } }) |
There was a problem hiding this comment.
did you mean to leave this here?
Ghost-in-a-Jar
approved these changes
Aug 13, 2024
samanehsan
approved these changes
Aug 13, 2024
…roadinstitute/sam into tl_ID-1353_sam_user_favorite_resources
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-1353
<Don't forget to include the ticket number in the PR title!>
What:
We're migrating favorite resources out of Thurloe! This PR adds support for favorite resources in Sam
Why:
Thurloe's user profile functionality is being deprecated and migrated to other services. Since Sam stores both Users and Resources, it makes sense for Sam to store a User's favorite resources.
How:
Just your standard API to DB implementation.
Note: If a user must have access to a resource to be able to favorite it. This is so that a user cannot probe Sam to find out what resources might exist by seeing what can and can't be favorited. The same constraint does not apply to removing a favorite resource, since a user who loses access to a resource probably wants to remove it from their favorites.
PR checklist