ID-1333 Add group version increment to onPolicyUpdate #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghost-in-a-Jar
changed the title
tlangs
approved these changes
Jul 15, 2024
Ghost-in-a-Jar
commented
Jul 15, 2024
| _ <- directoryDAO.updateGroupUpdatedDateAndVersionWithSession( | ||
| FullyQualifiedPolicyId(policyId.resource, policyId.accessPolicyName), | ||
| samRequestContext | ||
| ) |
There was a problem hiding this comment.
Note that the next thing that happens is onPolicyUpdateIfChanged which calls onPolicyUpdate if the policy actually changed.
Ghost-in-a-Jar
force-pushed
the
PROD-972-add-policy-update-group-version-increment
branch
from
8d36f73 to
f425110
Compare
|
Ghost-in-a-Jar
deleted the
PROD-972-add-policy-update-group-version-increment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-1333
What:
This adds group version incrementation to onPolicyUpdate which should cover our bases as far as policy member updates are concerned. It was a mistake to not add it here in the first place and instead try to put it a level up, we missed some areas where memberships are updated.
We also had to make sure group versions are updated for nested policy groups constrained by an auth domain
Why:
Users removed from auth domains are not losing access to google resources.