Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-1915: align rawls-swat-test-job to what Rawls currently does #1473

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Jul 1, 2024

Ticket: https://broadworkbench.atlassian.net/browse/AJ-1915

What:

three changes to the rawls-swat-test-job github action in this PR:

  1. Upgrade broadinstitute/workflow-dispatch from v3 to v4. I have not tackled upgrading all usages of broadinstitute/workflow-dispatch in Sam; there are others still on v3.
  2. Set a run-name value for each iteration of the test matrix. This solves the problem where the github action UI linked to the same terra-github-workflows test run for all three iterations of the matrix, making it much easier to navigate directly to a specific test suite.
  3. Align the test matrix to what Rawls is currently using. Specifically, this removes the AJ tests which were running 0 tests and were removed in Rawls back in AJ-1549: streamline GHA swat tests rawls#2800, and it splits the workspaces tests into two groups for concurrency; this was done in [NO TICKET] Split workspaces-owned swat tests into 2 groups rawls#2897.

See Rawls' implementation at https://github.com/broadinstitute/rawls/blob/cf8c3fcff774dca5346e5596554098e1852ba78c/.github/workflows/rawls-build-tag-publish-and-run-tests.yaml#L158-L204.

Why:

Make swat tests more performant and more useful.

How:

Assuming Sam will continue to run Rawls and Orch swat tests, it would be great to centralize code to prevent divergence like this. I have not tried to tackle that in this PR.


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

Copy link

sonarqubecloud bot commented Jul 2, 2024

@davidangb davidangb changed the title workflow dispatch 4 for rawls tests align rawls-swat-test-job to what Rawls currently does Jul 2, 2024
@davidangb davidangb marked this pull request as ready for review July 2, 2024 15:49
@davidangb davidangb changed the title align rawls-swat-test-job to what Rawls currently does AJ-1915: align rawls-swat-test-job to what Rawls currently does Jul 2, 2024
@davidangb davidangb merged commit a260a1a into develop Jul 2, 2024
24 checks passed
@davidangb davidangb deleted the da_workflowDispatch branch July 2, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants