ID-1285 switch open api to only oauth2 security scheme #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoet
commented
May 30, 2024
| @@ -11,6 +11,7 @@ start() { | |||
| docker create --name "${CONTAINER}" \ | |||
| --restart "always" \ | |||
| -p 40080:80 -p 50443:443 \ | |||
| -e "B2C_APPLICATION_ID=${OIDC_CLIENT_ID}" \ | |||
There was a problem hiding this comment.
fixes local deployment to do the audience check correctly
dvoet
commented
May 30, 2024
|
dvoet
commented
May 31, 2024
Comment on lines
+4755
to
+4757
| scopes: {} | ||
| tokenUrl: OAUTH_TOKEN_URL |
There was a problem hiding this comment.
replacements for OAUTH_AUTHORIZATION_URL and OAUTH_TOKEN_URL were implemented in workbenchLibs
Ghost-in-a-Jar
approved these changes
Jun 3, 2024
tlangs
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-1285
<Don't forget to include the ticket number in the PR title!>
What:
<For your reviewers' sake, please describe in a sentence or two what this PR is accomplishing (usually from the users' perspective, but not necessarily).>
Why:
<For your reviewers' sake, please describe in ~1 paragraph what the value of this PR is to our users or to ourselves.>
How:
<For your reviewers' sake, please describe in ~1 paragraph how this PR accomplishes its goal.>
<If the PR is big, please indicate where a reviewer should start reading it (i.e. which file or function).>
PR checklist