[DCJ-357] Add TDR managed offers to sam.conf #1436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/DCJ-357
What:
Using #1303 as a guide, added TDR's private managed application offers to Sam configuration.
Why:
This will enable TDR to call Sam's createManagedResourceGroup endpoint when creating new billing profiles. This Sam endpoint does the following:
Right now, TDR performs its own access checks on the TDR MRG. I'm not sure yet if we'll be able to remove them, though.
All of this is a prerequisite for TDR to use Sam's createActionManagedIdentity endpoint to mint new UAMIs for TDR MRGs.
How:
Besides this configuration change, we also had to publish a new version of the tdr-dev managed app offer which makes the terra-workspace-dev Azure group an Owner of the offer. This was needed so that Sam's service principals are allowed to operate in TDR MRGs. Slack
Unfortunately, offer changes are not retroactive to already deployed apps, so I had to deploy a new TDR managed application in order to test this out on my BEE. I documented that process through step 5 here: https://broadworkbench.atlassian.net/wiki/spaces/DCJ/pages/3165519875/20240521+Manual+POC+accessing+a+private+storage+account+within+TDR+MRG
Notable is that I was able to manually link a TDR billing profile to its MRG coords through this endpoint, and then subsequently use Sam to create an UAMI off of it!
PR checklist