New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID-1230 Ensure Audit Log Events Have Same Schema #1431

Merged

tlangs merged 1 commit into develop from tl_ID-1230_sam_audit_log_schema_convergence

May 7, 2024

Contributor

tlangs commented May 7, 2024

Ticket: https://broadworkbench.atlassian.net/browse/ID-1230

It appears that if two log events have the same member names, but those members are different types, then BigQuery cannot handle both. This PR makes the changeEvents on Audit Log Events be Sets, instead of one being an Option and the other being a Set, so that BigQuery has a consistent schema for log entries.

PR checklist

I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket


          ID-1230 Ensure Audit Log Events Have Same Schema

a8fc134

sonarqubecloud bot commented May 7, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

samanehsan approved these changes

View reviewed changes

tlangs enabled auto-merge (squash)

May 7, 2024 15:48

Ghost-in-a-Jar approved these changes

View reviewed changes

tlangs merged commit 4f085fb into develop

15 checks passed

tlangs deleted the tl_ID-1230_sam_audit_log_schema_convergence branch

May 7, 2024 15:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet