Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-1263 Correct Error Deleting Action Managed Identities #1420

Merged
merged 3 commits into from
May 2, 2024

Conversation

tlangs
Copy link
Contributor

@tlangs tlangs commented May 2, 2024

Ticket: https://broadworkbench.atlassian.net/browse/ID-1263

When deleting action managed identities, the query didn't use the composite sam_resource_action.action sam_resource_action.resourceTypeId key when getting Action Managed Identities to delete. This meant that the subquery returned resource action id's for any action name, even if two different actions on different resource types had the same name. This caused a sql error where a subquery returned more than one result. No bueno!

Corrected the bug. This is brand new functionality, so bugs like this are bound to happen!


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

Copy link
Contributor

@rtitle rtitle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing!

Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tlangs tlangs enabled auto-merge (squash) May 2, 2024 14:29
@tlangs tlangs merged commit bdb3d2e into develop May 2, 2024
15 checks passed
@tlangs tlangs deleted the tl_ID-1263_error_deleting_aami branch May 2, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants