[TOAZ-355] [TOAZ-356] Use Managed Identity auth when running Azure Control Plane, support for Service Catalog deployed Azure Managed Apps #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
April 9, 2024 15:21
…nd Service Principal auth
dvoet
reviewed
May 8, 2024
dvoet
reviewed
May 8, 2024
src/main/scala/org/broadinstitute/dsde/workbench/sam/azure/CrlService.scala
Outdated
Show resolved
Hide resolved
rtitle
reviewed
May 8, 2024
src/main/scala/org/broadinstitute/dsde/workbench/sam/azure/AzureService.scala
Show resolved
Hide resolved
rtitle
reviewed
May 8, 2024
src/main/scala/org/broadinstitute/dsde/workbench/sam/azure/CrlService.scala
Show resolved
Hide resolved
rtitle
reviewed
May 8, 2024
added 5 commits
May 13, 2024 20:39
dvoet
reviewed
May 16, 2024
src/main/scala/org/broadinstitute/dsde/workbench/sam/azure/AzureService.scala
Outdated
Show resolved
Hide resolved
dvoet
reviewed
May 16, 2024
src/main/scala/org/broadinstitute/dsde/workbench/sam/config/AppConfig.scala
Outdated
Show resolved
Hide resolved
dvoet
reviewed
May 16, 2024
src/main/scala/org/broadinstitute/dsde/workbench/sam/config/AzureServicesConfig.scala
Outdated
Show resolved
Hide resolved
dvoet
previously requested changes
May 16, 2024
src/main/scala/org/broadinstitute/dsde/workbench/sam/Boot.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/broadinstitute/dsde/workbench/sam/azure/AzureService.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/broadinstitute/dsde/workbench/sam/azure/AzureService.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/broadinstitute/dsde/workbench/sam/azure/AzureService.scala
Outdated
Show resolved
Hide resolved
aaronegrant
dismissed
dvoet’s stale review
Refactor of validateAuthorizedAppUser completed
dvoet
reviewed
May 21, 2024
src/main/scala/org/broadinstitute/dsde/workbench/sam/azure/AzureService.scala
Outdated
Show resolved
Hide resolved
…ic for deciding when to check for ServiceCatalogManagedApps vs MarketplaceManagedApps
added 5 commits
May 23, 2024 10:37
dvoet
approved these changes
May 24, 2024
Shakespeared
suggested changes
May 28, 2024
Shakespeared
approved these changes
May 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor SAM ARM authorization code to support using a Managed Identity app id instead of Service Principal clientid/clientsecret
Service Catalog deployed app support:
Sam maintains its own list of Terra managed app plans https://github.com/broadinstitute/sam/blob/develop/src/main/resources/sam.conf#L192 and validates a billing profile managed app against this list during billing profile creation.
Service catalog managed apps do not have a plan defined so we will need change the validation in Sam to accept this.