ID-1109 Fix Admin PATCH User Endpoint #1362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-1109
When using the admin PATCH User endpoint to update the
googleSubjectId
andazureB2CId
for a user at the same time, a database exception occurs. In the query construction, the positions of the new IDs were swapped, meaning theazureB2CId
was being saved as agoogleSubjectId
. Thankfully, the database disallowed the update, as theazureB2CId
UUID was too long for thegoogleSubjectId
column.I've re-worked the logic and added a test to make sure setting both ids works correctly.
PR checklist