ID-1046 Migrate listResourcesAndPoliciesV2 to new query #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghost-in-a-Jar
approved these changes
Jan 29, 2024
tlangs
changed the title
tlangs
changed the title
|
| samUser: SamUser, | ||
|
|
||
| private val publicResourcesCache: java.util.Map[ResourceTypeName, Seq[FilterResourcesResult]] = | ||
| Collections.synchronizedMap(new PassiveExpiringMap(1, TimeUnit.HOURS)) |
There was a problem hiding this comment.
1 hour seems like a while, am i correct in thinking that if someone changes a public resource itll take an hour to propagate that change? Do you see that causing any problems?
There was a problem hiding this comment.
I don't think it would be a problem. Publicizing workspaces is a manual process undertaken by Support, so we can just instruct them that it can take up to an hour for a public workspace to appear.
Ghost-in-a-Jar
approved these changes
Jan 30, 2024
samanehsan
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
What:
Instead of making everyone else migrate to a new
listResourcesV2endpoint, why not just change the query powering thelistResourcesAndPoliciesV2under the hood?Why:
Lessen the load on everyone else.
How:
Adapt the db response to the response type of
listResourcesAndPoliciesV2PR checklist