Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA-2168: Refactor provider tests to use app version tag (semvar) #1253

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

ichengchang
Copy link
Contributor

@ichengchang ichengchang commented Nov 14, 2023

QA-2168: <Link to Jira ticket>

What:

We need to migrate from Git hash to semvar for all repositories that currently publish consumer pacts or run provider verification tests. These repositories are known as pacticipants when they have been enrolled or enabled in Sherlock for contract testings.

Why:

Sherlock now relies on semvar (aka application version) to push deployment notifications to Pact Broker. We need this PR to ensure the consistency of the versioning scheme used by Sherlock and Pact Broker.

How:

Deprecate PROVIDER_SHA in favor of PROVIDER_VERSION


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

@ichengchang ichengchang changed the title Refactor provider tests to use app version tag (semvar) QA-2168: Refactor provider tests to use app version tag (semvar) Nov 14, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ichengchang ichengchang merged commit 31b47ba into develop Nov 14, 2023
16 of 17 checks passed
@ichengchang ichengchang deleted the QA-2168 branch November 14, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants