Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID-808, ID-809 Implement PUT /api/termsOfService/v1/user/self/accept and reject #1249

Merged
merged 2 commits into from
Nov 9, 2023
Merged

ID-808, ID-809 Implement PUT /api/termsOfService/v1/user/self/accept and reject #1249

merged 2 commits into from
Nov 9, 2023

Conversation

Ghost-in-a-Jar
Copy link
Contributor

@Ghost-in-a-Jar Ghost-in-a-Jar commented Nov 9, 2023 •
edited
Loading

Ticket: https://broadworkbench.atlassian.net/browse/ID-808
https://broadworkbench.atlassian.net/browse/ID-809

What:

When the user sends an empty PUT request to /api/termsOfService/v1/user/self/accept or reject they will accept/reject the tos and receive a successful 204 No Content response (empty body)

Why:

More streamlined api/endpoint

How:

Other aspects of the tos acceptance code are already covered by tests so this is a really simple pr.

PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

@Ghost-in-a-Jar Ghost-in-a-Jar force-pushed the ID-808-add-tos-accept-self branch from f226999 to 2e3b4db Compare November 9, 2023 21:55
@Ghost-in-a-Jar Ghost-in-a-Jar changed the title ID-808 Implement PUT /api/termsOfService/v1/user/self ID-808 Implement PUT /api/termsOfService/v1/user/self/accept Nov 9, 2023
@Ghost-in-a-Jar Ghost-in-a-Jar changed the title ID-808 Implement PUT /api/termsOfService/v1/user/self/accept ID-808 Implement PUT /api/termsOfService/v1/user/self/accept and reject Nov 9, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ghost-in-a-Jar Ghost-in-a-Jar changed the title ID-808 Implement PUT /api/termsOfService/v1/user/self/accept and reject ID-808, ID-809 Implement PUT /api/termsOfService/v1/user/self/accept and reject Nov 9, 2023
@Ghost-in-a-Jar Ghost-in-a-Jar merged commit 2027ee1 into develop Nov 9, 2023
15 checks passed
@Ghost-in-a-Jar Ghost-in-a-Jar deleted the ID-808-add-tos-accept-self branch November 9, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjkobori sjkobori sjkobori approved these changes

@tlangs tlangs tlangs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ghost-in-a-Jar @tlangs @sjkobori