Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID-901 Add pact publish boolean #1239

Merged
merged 2 commits into from
Nov 8, 2023
Merged

ID-901 Add pact publish boolean #1239

merged 2 commits into from
Nov 8, 2023

Conversation

Ghost-in-a-Jar
Copy link
Contributor

Ticket: https://broadworkbench.atlassian.net/browse/ID-901

What:

Disabling pact publishing by default and enabling it in CI.

Why:

Publishing shouldn't happen when running locally.

How:

Added an env variable PACT_PUBLISH_RESULTS that defaults to false.

PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ichengchang
ichengchang approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@ichengchang ichengchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Ghost-in-a-Jar Ghost-in-a-Jar merged commit d4fa643 into develop Nov 8, 2023
16 checks passed
@Ghost-in-a-Jar Ghost-in-a-Jar deleted the add-pact-publish-boolean branch November 8, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjkobori sjkobori sjkobori approved these changes

@ichengchang ichengchang ichengchang approved these changes

@tlangs tlangs tlangs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ghost-in-a-Jar @tlangs @ichengchang @sjkobori