Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to pact readme. #1233

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Add to pact readme. #1233

merged 3 commits into from
Oct 31, 2023

Conversation

Ghost-in-a-Jar
Copy link
Contributor

Just adding a bit to the readme for pact

PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

gpolumbo-broad
gpolumbo-broad suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@gpolumbo-broad gpolumbo-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add link in the main README that for Pact/Contract testing instructions, users should read this README

@Ghost-in-a-Jar Ghost-in-a-Jar force-pushed the add-to-pact-readmy branch 2 times, most recently from b1b3076 to 64a02e8 Compare October 31, 2023 18:32
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Ghost-in-a-Jar Ghost-in-a-Jar merged commit 8b3a9aa into develop Oct 31, 2023
16 checks passed
@Ghost-in-a-Jar Ghost-in-a-Jar deleted the add-to-pact-readmy branch October 31, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjkobori sjkobori sjkobori approved these changes

@gpolumbo-broad gpolumbo-broad gpolumbo-broad approved these changes

@Shakespeared Shakespeared Shakespeared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ghost-in-a-Jar @Shakespeared @gpolumbo-broad @sjkobori