ID-896 Isolate Misbehaving Query #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shakespeared
approved these changes
Oct 26, 2023
jack-r-warren
approved these changes
Oct 26, 2023
dvoet
reviewed
Oct 26, 2023
dvoet
reviewed
Oct 26, 2023
gpolumbo-broad
approved these changes
Oct 26, 2023
dvoet
reviewed
Oct 26, 2023
| @@ -1353,7 +1357,7 @@ class PostgresAccessPolicyDAO(protected val writeDbRef: DbReference, protected v | |||
| userId: WorkbenchUserId, | |||
| samRequestContext: SamRequestContext | |||
| ): IO[Iterable[ResourceIdWithRolesAndActions]] = | |||
| readOnlyTransaction("listUserResourcesWithRolesAndActions", samRequestContext) { implicit session => | |||
| readOnlyTransactionReadReplica("listUserResourcesWithRolesAndActions", samRequestContext) { implicit session => | |||
There was a problem hiding this comment.
do you want to do this for all usages of UserResourcesQuery?
There was a problem hiding this comment.
Not sure. The query that's been blowing up the DB seems to be the one with as inherited in it. Being as surgical as possible seems like the right move here.
There was a problem hiding this comment.
I vote that given where we are with this, we isolate this one major offender first. 80/20 rule. We might be able to make things a lot better at some point, but for now we just need to treat the most severe problem.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-896
<Don't forget to include the ticket number in the PR title!>
What:
Isolate the misbehaving query to the read replica. All other read/writes go to the main db.
Why:
Read replicas have lag.
How:
Introduce a new
DbReferenceto isolate misbehaving queries.PR checklist