ID-807 New get ToS endpoints for user #1229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
October 23, 2023 15:32
…eDetails`. Introduce new `TermsOfServiceDetails`
… because of PostgresDirectoryDAOSpec, so adding the correct `assume` statements back into all the tests
…icated and unauthenticated routes both work
… for users are returned or denied properly
…ng AND requested user so that we can properly authorize requests
gpolumbo-broad
commented
Oct 26, 2023
| @@ -11,7 +11,7 @@ import org.broadinstitute.dsde.workbench.sam.db.TestDbReference | |||
| import org.broadinstitute.dsde.workbench.sam.db.tables.TosTable | |||
| import org.broadinstitute.dsde.workbench.sam.matchers.TimeMatchers | |||
| import org.broadinstitute.dsde.workbench.sam.model._ | |||
| import org.broadinstitute.dsde.workbench.sam.model.api.SamUserAttributes | |||
| import org.broadinstitute.dsde.workbench.sam.model.api.{SamUser, SamUserAttributes} | |||
There was a problem hiding this comment.
There are a lot of changes in this file, but they should not be scary.
- scalafmt and adding types to some variables
- adding the
assumestatement to each individual test because the tests were erroring for me locally when I only had it at the top of the suite.
added 7 commits
October 26, 2023 11:42
gpolumbo-broad
changed the title
Ghost-in-a-Jar
approved these changes
Oct 31, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-807
What:
Endpoints for getting a user's ToS status/details for themselves or for another user if they are an admin
Why:
<For your reviewers' sake, please describe in ~1 paragraph what the value of this PR is to our users or to ourselves.>
How:
<For your reviewers' sake, please describe in ~1 paragraph how this PR accomplishes its goal.>
<If the PR is big, please indicate where a reviewer should start reading it (i.e. which file or function).>
PR checklist