ID-891 Optimize UserResourcesQuery

[Ghost-in-a-Jar]

Ticket: https://broadworkbench.atlassian.net/browse/ID-891

What/why:

This query is accounting for the majority of the cpu load in sam, for some reason postgres is doing a full table scan of sam_effective_resource_policy every single time the query is ran, despite there being indexes on the table. This modification forces the join of sam_effective_resource_policy to filter down to only resource_ids of the type we are looking for.

How:

This modification to the query should be functionally equivalent, but forces the postgres query planner to do an index scan instead of a full table scan:

before
-> Parallel Seq Scan on sam_effective_resource_policy effpol (cost=0.00..14559.75 rows=537375 width=24)
after
-> Index Scan using idx_erp_resource_id on sam_effective_resource_policy effpol (cost=0.43..0.63 rows=6 width=24)

---

PR checklist

• I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
• I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

[dvoet]

made a suggestion for now or for the future

[dvoet]

if you want to go a little further

Suggested change

	join ${ResourceTypeTable as resourceType} on ${resourceType.id} = ${resource.resourceTypeId}
	where ${resourceType.name} = ${resourceTypeName}
	where ${resource.resourceTypeId} = ${resourceTypePKsByName(resourceTypeName)}

also could remove the ResourceTypeTable join and replace

where ${resourceType.name} = ${resourceTypeName}

with

where ${resource.resourceTypeId} = ${resourceTypePKsByName(resourceTypeName)}

[tlangs]

Lets test on Dev and make sure that the query is returning everything and behaving as we expect. Once that's done, to prod we go!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[Ghost-in-a-Jar]

@tlangs I ran:

(select * from optimized EXCEPT select * from original)
UNION ALL
(select * from original EXCEPT select * from optimized)

and that returned nothing so they are returning the same rows