Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID-883 adjusted scalafmt rules to fix obnoxious indenting in Route files #1220

Merged
merged 3 commits into from
Oct 23, 2023
Merged

ID-883 adjusted scalafmt rules to fix obnoxious indenting in Route files #1220

merged 3 commits into from
Oct 23, 2023

Conversation

gpolumbo-broad
Copy link
Contributor

Ticket: https://broadworkbench.atlassian.net/browse/ID-883

What:

Fixes annoying scalafmt indentation in Akka Routes definitions

Why:

The routes are ugly and hard enough to read already

How:

look at scalafmt.conf first

PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

sjkobori
sjkobori approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@sjkobori sjkobori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

Greg Polumbo added 2 commits October 23, 2023 11:25
Merge branch 'develop' into ID-883-scalafmt-routes
5700db2 
# Conflicts:
#	src/main/scala/org/broadinstitute/dsde/workbench/sam/api/UserRoutesV2.scala
ID-883 update branch with develp
bba1bc1
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gpolumbo-broad gpolumbo-broad merged commit 4a55ba5 into develop Oct 23, 2023
26 checks passed
@gpolumbo-broad gpolumbo-broad deleted the ID-883-scalafmt-routes branch October 23, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjkobori sjkobori sjkobori approved these changes

@Ghost-in-a-Jar Ghost-in-a-Jar Ghost-in-a-Jar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpolumbo-broad @Ghost-in-a-Jar @sjkobori