Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-807 stubbing out Routes for new ToS routes #1213

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

gpolumbo-broad
Copy link
Contributor

Ticket: https://broadworkbench.atlassian.net/browse/ID-807 (and other tickets that need new ToS routes

What:

Stubbed Akka Routes all returning 501 just to get them in place so we don't end up stepping on each other as we implement the new routes.

Why:

Because akka routing is gross, and scalafmt makes it even worse, and I really really don't want to have to do manual code merges in a yucky file.

How:

<For your reviewers' sake, please describe in ~1 paragraph how this PR accomplishes its goal.>

<If the PR is big, please indicate where a reviewer should start reading it (i.e. which file or function).>


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gpolumbo-broad gpolumbo-broad merged commit a321af9 into develop Oct 23, 2023
22 checks passed
@gpolumbo-broad gpolumbo-broad deleted the ID-807-Stubbed-tos-endpoints branch October 23, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants