[PF-2972] Update dependencies with known vulnerabilities #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Qi77Qi
reviewed
Nov 28, 2023
There was a problem hiding this comment.
seems reasonable to me..but I don't maintain Sam, so I'll defer to @Ghost-in-a-Jar @tlangs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: PF-2972
What:
Update a number of dependencies with known vulnerabilities. This also changes a few of the integration test ones which were flagged, but I didn't want to modify those too much as I'm not sure how to run the Sam integration tests to validate.
Why:
Verily security has started using a different dependency analysis tool which flagged a handful of vulnerabilities. I'd like to update dependencies to fix issues raised by both Verily's tool and Sourceclear.
PR checklist