Skip to content

Commit

Permalink
[DCJ-400] #major pre-releases use -snapshot suffix
Browse files Browse the repository at this point in the history
Such as the client builds generated as part of PR commits.

Many Terra services use Dependabot to automate dependency upgrades.
Dependabot will ignore new versions with `-snapshot` suffix and rightfully interpret them as prereleases.

Also tagging this as a major release to bring Sam client versions up to 1.0.0, past older versions pre-semver.  My earlier attempt to do so did not properly trigger client publication on account of being a no-code commit.
  • Loading branch information
okotsopoulos committed Sep 4, 2024
1 parent 8dd6103 commit 406b0f3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions codegen_java/project/Version.scala
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ object Version {

// The project isSnapshot string passed in via command line settings, if desired.
val isSnapshot = sys.props.getOrElse("project.isSnapshot", "true").toBoolean

// For now, obfuscate SNAPSHOTs from sbt's developers: https://github.com/sbt/sbt/issues/2687#issuecomment-236586241
if (isSnapshot) s"$semVer-SNAP" else semVer
if (isSnapshot) s"$semVer-snapshot" else semVer
}
}
4 changes: 1 addition & 3 deletions codegen_java_old/project/Version.scala
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ object Version {

// The project isSnapshot string passed in via command line settings, if desired.
val isSnapshot = sys.props.getOrElse("project.isSnapshot", "true").toBoolean

// For now, obfuscate SNAPSHOTs from sbt's developers: https://github.com/sbt/sbt/issues/2687#issuecomment-236586241
if (isSnapshot) s"$semVer-SNAP" else semVer
if (isSnapshot) s"$semVer-snapshot" else semVer
}
}

0 comments on commit 406b0f3

Please sign in to comment.