Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dual License #32

Merged
merged 5 commits into from
Jul 2, 2020
Merged

Adding Dual License #32

merged 5 commits into from
Jul 2, 2020

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented May 12, 2020

We have chosen to dual license this repository. The code will be licensed using BSD-3 Clause while the underlying data, results, and figures will be licensed with CC0 1.0

This PR adds the two license files and adds a license note in the README.

The permissive open source nature of the project will enable rapid sharing of the data, increased speed of method development in Cell Painting projects, and will increase participation of people around the world who find this data. Science progresses faster and more fairly without access barriers.

Closes #27

@gwaybio gwaybio requested a review from shntnu May 12, 2020 15:35
@shntnu
Copy link
Collaborator

shntnu commented May 12, 2020

How about we do things in this order (feel free to edit this) @gwaygenomics

  • Get all the Level 3-5 data on master @gwaygenomics
  • Create a manifest file linking to the files living in this repo @shntnu Create manifest file for clue.io #33
  • Send the manifest to clue.io (but we don't need to wait for the data to go up on clue.io) @gwaygenomics
  • Update the README in this PR, citing clue.io as the data source @gwaygenomics
  • Share this PR with clue.io @shntnu
  • Get their sign off @shntnu
  • approve this PR @shntnu
  • Merge PR @gwaygenomics

@gwaybio
Copy link
Member Author

gwaybio commented May 12, 2020

let's do it! One small note is that we may not necessarily want to block ourselves by waiting on clue. If we get a sense that it will take long for them to update clue.io and sign off on this PR, we can always open a new PR.

Also, can we have clue sign off on this PR now?

@shntnu
Copy link
Collaborator

shntnu commented May 12, 2020

may not necessarily want to block ourselves by waiting on clue.

The only step blocking is this one, correct? "Share this PR with clue.io and get their sign off then approve this @shntnu" None of the others are.

This one "Update the README in this PR, citing clue.io as the data source @gwaygenomics" is not blocking because we can always cite clue.io as the data generators in the README but have the actual data go up later

@shntnu
Copy link
Collaborator

shntnu commented May 12, 2020

  • Create a manifest file linking to the files living in this repo @shntnu

@gwaygenomics Can you confirm that SQ00015153_augmented.csv.gz will be available at this location:

https://raw.githubusercontent.com/broadinstitute/lincs-cell-painting/master/profiles/2016_04_01_a549_48hr_batch1/SQ00015153/SQ00015153_augmented.csv.gz

@gwaybio
Copy link
Member Author

gwaybio commented May 12, 2020

as per #23 I add a backend folder in there

A more accurate link is:

https://raw.githubusercontent.com/broadinstitute/lincs-cell-painting/master/profiles/backend/2016_04_01_a549_48hr_batch1/SQ00015153/SQ00015153_augmented.csv.gz

Edit - I just saw cytomining/profiling-handbook#54 (comment)! so yes, your link is correct.

The other files that exist in this structure have the format (with the plate prefix syntax)

  1. .csv.gz
  2. _augmented.csv.gz
  3. _normalized.csv.gz
  4. _normalized_dmso.csv.gz
  5. _normalized_feature_select.csv.gz
  6. _normalized_feature_select_dmso.csv.gz

@gwaybio
Copy link
Member Author

gwaybio commented May 12, 2020

@shntnu - note the edit to the path above

@shntnu
Copy link
Collaborator

shntnu commented May 22, 2020

@gwaygenomics can you go ahead and sync this fork?

You do this, correct?:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

@shntnu
Copy link
Collaborator

shntnu commented May 22, 2020

Sync after merging this #45

Copy link
Collaborator

@shntnu shntnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after my email to Aravind on Jul 2 2020

@shntnu
Copy link
Collaborator

shntnu commented Jul 2, 2020

@gwaygenomics All set for you to merge after syncing this fork as needed

@gwaybio
Copy link
Member Author

gwaybio commented Jul 2, 2020

😎

@gwaybio gwaybio merged commit da8ae6a into broadinstitute:master Jul 2, 2020
@gwaybio gwaybio deleted the add-license branch July 2, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add License
2 participants