Skip to content

Commit

Permalink
Finish debugging custom analysis with BB feature
Browse files Browse the repository at this point in the history
(realized that I had forgotten to add this last tiny commit in my PR)
  • Loading branch information
snwessel committed Jan 9, 2025
1 parent 0671880 commit cd53521
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions portal-backend/depmap/breadbox_shim/breadbox_shim.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
FeatureResponse,
ValueType,
)
from depmap import data_access
from depmap.data_access.response_parsing import (
format_breadbox_task_status,
get_breadbox_slice_id,
parse_breadbox_slice_id,
remove_breadbox_prefix,
)
from depmap.interactive.config.categories import CustomCellLinesConfig
from depmap.vector_catalog.models import Node, NodeType
Expand Down Expand Up @@ -233,7 +233,7 @@ def run_custom_analysis(
or a legacy portal feature (specified with the given feature_data).
Return a task status.
"""
dataset_uuid = parse_breadbox_slice_id(dataset_slice_id).dataset_id
bb_dataset_id = remove_breadbox_prefix(dataset_slice_id)
if slice_query:
# Temporary hack: for now, this slice query ALWAYS specifies a feature by label.
# This should always be true for our current feature selection component.
Expand All @@ -259,7 +259,7 @@ def run_custom_analysis(
query_dataset_id = ""
bb_task_status = extensions.breadbox.client.compute_univariate_associations(
analysis_type=analysis_type,
dataset_id=dataset_uuid,
dataset_id=bb_dataset_id,
query_feature_id=feature_id,
query_dataset_id=query_dataset_id,
vector_variable_type=vector_variable_type,
Expand Down
1 change: 1 addition & 0 deletions portal-backend/depmap/compute/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ def post(self):
query_cell_lines: list[
str
] = legacy_data_slice.index.tolist() # pyright: ignore
slice_query = None
return breadbox_shim.run_custom_analysis(
analysis_type=analysis_type,
dataset_slice_id=dataset_id,
Expand Down

0 comments on commit cd53521

Please sign in to comment.