Make it easy for Roda routes to render "callable" objects #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://bridgetown-beta-pr-892.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-copqcdmv3ddc73fp24bg. |
|
Your Render PR Server URL is https://bridgetown-api-pr-892.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-copqce6v3ddc73fp24j0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup and enhancements made possible by utilizing Roda's custom_block_results plugin more effectively…including even letting you return components as route results. There's some more cleanup I want to do that will enable #561 as well. This is also the start of a new evaluation of places in the framework where we can leverage the "callable" object pattern.
Oh yeah, also added in a
sitealias so no more having to rememberbridgetown_sitein Roda routes. Hurray!