Allow consistent permitting classes #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Bridgetown expects to be able to load its special Rb class for YAML front matter. The original implementation made it hard to have extra permitted classes in front matter while retaining that expectation. This change makes it so the default permitted classes are merged into any passed permitted classes across both string and file loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
By default, Bridgetown expects to be able to load its special Rb class for YAML front matter. The original implementation made it hard to have extra permitted classes in front matter while retaining that expectation.
This change makes it so the default permitted classes are merged into any passed permitted classes across both string and file loading.
Context
While digging into ways that we could have a consistent YAML store for #777, I discovered this papercut.