Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports embedded images #200

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Supports embedded images #200

wants to merge 5 commits into from

Conversation

Copy link

github-actions bot commented Jan 12, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

bric3 and others added 3 commits August 27, 2024 00:48
This was contributed by @lionelhorn. Approach is to wait for
the "update" message that has the embedded files then create
`initialData` with the files and only then render the
Excalidraw component.

Mobx is used for state management replacing react `useState`.
Which is easier to get the code a bit cleaner code
than passing the setters of `useState` to the bridge.

Co-authored-by: Lionel <[email protected]>
@bric3
Copy link
Owner Author

bric3 commented Aug 27, 2024

Thanks to @lionelhorn with is clever observation on initialData.

Original work: lionelhorn@6fd259f

@bric3 bric3 added the enhancement New feature or request label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle embedded images added to a drawing
1 participant