-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports embedded images #200
base: main
Are you sure you want to change the base?
Conversation
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: true Contact Qodana teamContact us at [email protected]
|
This was contributed by @lionelhorn. Approach is to wait for the "update" message that has the embedded files then create `initialData` with the files and only then render the Excalidraw component. Mobx is used for state management replacing react `useState`. Which is easier to get the code a bit cleaner code than passing the setters of `useState` to the bridge. Co-authored-by: Lionel <[email protected]>
Thanks to @lionelhorn with is clever observation on Original work: lionelhorn@6fd259f |
Current code has to both
Fixes: #199
See
Might be of help:
Doc