Merge pull request #9 from brennerm/fix-argument-validation

fix check key argument validation
brennerm · Mar 17, 2021 · 64317d6 · 64317d6
2 parents fdc151c + bf99607
commit 64317d6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.3.1] - 2021-03-17
+
+### Fixed
+
+- fix check key validation for _check_ and _prometheus-exporter_ subcommands
+
 ## [1.3.0] - 2021-03-12
 
 ### Added

diff --git a/aws_quota/cli.py b/aws_quota/cli.py
@@ -133,7 +133,7 @@ def common_check_options(function):
 @cli.command()
 @common_scope_options
 @common_check_options
-@click.argument('check-keys', type=ALL_CHECKS_CHOICE)
+@click.argument('check-keys')
 def check(check_keys, region, profile, warning_threshold, error_threshold, fail_on_warning):
     """Run checks identified by CHECK_KEYS
 
@@ -206,7 +206,7 @@ def check_instance(check_key, instance_id, region, profile, warning_threshold, e
 @click.option('--currents-check-interval', help='Interval in seconds at which to check the current quota value, defaults to 300', default=300)
 @click.option('--reload-checks-interval', help='Interval in seconds at which to collect new checks e.g. when a new resource has been created, defaults to 600', default=600)
 @click.option('--enable-duration-metrics/--disable-duration-metrics', help='Flag to control whether to collect/expose duration metrics, defaults to true', default=True)
-@click.argument('check-keys', type=ALL_CHECKS_CHOICE)
+@click.argument('check-keys')
 def prometheus_exporter(check_keys, region, profile, port, namespace, limits_check_interval, currents_check_interval, reload_checks_interval, enable_duration_metrics):
     """Start a Prometheus exporter for quota checks
 

diff --git a/setup.py b/setup.py
@@ -7,7 +7,7 @@
 
 setup(
     name='aws-quota-checker',
-    version='1.3.0',
+    version='1.3.1',
     description='A CLI tool that checks your AWS quota utilization',
     long_description=long_description,
     long_description_content_type='text/markdown',