difffolded.pl: add keep-all mode and propagation features #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a few new operational modes and filtering options to
difffolded.pl to help analyze differences between stack traces:
-k: Keep and show all stacks, including those with zero counts in
either file. This helps visualize stacks that are unique to
either the old or new profile.
-p: Propagate differences up the call stack by accumulating child
counts. This helps understand how changes in child functions
affect their parents' total time.
Additional filtering options that work across all modes:
-z: Elide frames where the difference between old and new is below
a threshold.
-Z NUM: Set the threshold for -z (default: 0.01).
These changes help users better understand performance changes by:
- Showing complete call hierarchies with -k
- Understanding impact on parent functions with -p
- Focusing on significant changes with -z/-Z
sean-
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new features to difffolded.pl to help analyze differences between
stack traces:
Default mode now only shows stacks present in both files, making it
easier to see changes in common code paths.
-k: Keep and show all stacks from both files, including those uniqueto either file. This helps visualize new or removed code paths
between profiles.
-p: Propagate differences by accumulating child counts up the stack.This flag can be used in both default and -k modes to understand
how changes in child functions affect their parents' total time.
Additional filtering options that work in all modes:
-z: Elide frames where the difference between old and new is belowa threshold.
-Z NUM: Set the threshold for-z(default:0.01).