Co-operative Close Channels #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
commented
May 7, 2024
erdemyerebasmaz
force-pushed
the
coop-close-chan
branch
3 times, most recently
from
25163cd to
166737f
Compare
erdemyerebasmaz
force-pushed
the
coop-close-chan
branch
4 times, most recently
from
ed5c23d to
476f2d7
Compare
erdemyerebasmaz
force-pushed
the
coop-close-chan
branch
from
476f2d7 to
0cf3bb8
Compare
erdemyerebasmaz
force-pushed
the
coop-close-chan
branch
from
0cf3bb8 to
0a2d793
Compare
- Display Next button at all times - Only validate address when Next is pressed - Display error messages on dialog instead of a flushbar - Add missing await for handling errors on closing channels cooperatively - Ensure account bloc is accessible on CoopCloseChannelsDialog - Address feedback on cooperative close channels UI - Update address validation & error handling - Display success & failure messages accordingly. - Update dependencies to latest - Increase compileSdkVersion to 34(Android camera & lifecycle requirement) - Use "given version or earlier" syntax for dependencies that require Flutter 3.10 - Remove unused import - Declare CloseChannels as account action - Refactoring - Open mail or share support mail when clicked - Minor UI revision, Dialog -> AlertDialog - Prevent dismissing dialog when closing channels is in progress - Update Breez-Translations dependency TODO: Change icon
erdemyerebasmaz
force-pushed
the
coop-close-chan
branch
from
0a2d793 to
38d90b4
Compare
erdemyerebasmaz
requested review from
roeierez and
JssDWt
and removed request for
roeierez and
JssDWt
erdemyerebasmaz
force-pushed
the
coop-close-chan
branch
from
1143aea to
76244e3
Compare
- Fix super calls on initState, didChangeDependencies, didUpdateWidget & dispose - Increase line length to 110 across the project - format generated files with 100 line length - ignore: overridden_fields for BreezDrawerHeader - ignore: deprecated_member_use_from_same_package for LSPInformation's channelFeePermyriad, maxInactiveDuration, channelMinimumFeeMsat. - ignore: missing_required_param for TextButton's wrapped with InkWell
Ran "dart format -l 110 ."
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the UI components required for changes in:
that introduces co-operative close channel operations.
Changelist:
Other changelist: