Add folder support for dashboards (#72). #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toran414
force-pushed
the
feature/dashboard-folders
branch
from
c80d495 to
49c1af8
Compare
toran414
force-pushed
the
feature/dashboard-folders
branch
from
49c1af8 to
50b5436
Compare
|
Pushes were to add extra commas that the build was failing without; didn't want to pollute the commit history. |
|
Very nice! Thanks a lot for the very awesome contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed #72 was opened but never had a pull opened for it. I added the support locally in our kube-prometheus implementation and tested it. It does indeed organize the provisioned dashboards into folders correctly. I also tested with no folderDashboards element to ensure backwards compatibility. Lastly added mention of the feature into the README.
Kind of new to jsonnet, so please let me know if there are any improvements that are needed, but this feature would be very helpful to us.