Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique namespace within a mount #158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

milkamil93
Copy link

Example:

$router->mount('/api/v1', function () use ($router) {
    $router->setNamespace('Source\Api\v1');
    $router->mount('/test', function () use ($router) {
        $router->setNamespace('Source\Api\v1\Test');
    });
});

@milkamil93 milkamil93 mentioned this pull request Aug 5, 2021
@uvulpos
Copy link
Collaborator

uvulpos commented Aug 5, 2021

LGTM if it works (did not test that yet), but please add some unit tests 😉 that would be icing on the cake 👍🏻

@milkamil93
Copy link
Author

LGTM if it works (did not test that yet), but please add some unit tests 😉 that would be icing on the cake 👍🏻

75d5c6e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants