Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
We would like to prevent #383 to happen again.
What does this PR do?
Writes a test for
connect_four
that reproduces #383, so we know it's fixed once we fix it.For now, the test is marked as XFAIL (expected to fail) - this test is the minimal example needed to justify why we need to use uint32 for the signal_array (for cases where we have >65535 - possibly temporary - struct_ids - see #386 )
I am reluctant to add assertions in the highly optimised part of the code, as this may affect performance.
References
A step on the way to closing #383.
How has this PR been tested?
The PR adds a well-documented test that was run locally.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: