Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unsupported notice for brainrender #111

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

alessandrofelder
Copy link
Member

⚠️ depends on brainglobe/brainrender#250 being merged first.

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We can support brainrender again (once brainglobe/brainrender#250 is merged) 🎉

What does this PR do?
Removes the unsupported notice for brainrender.

References

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review December 1, 2023 10:08
@alessandrofelder alessandrofelder merged commit db577e1 into main Dec 1, 2023
2 checks passed
@alessandrofelder alessandrofelder deleted the support-brainrender-again branch December 1, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants