Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add golangci-lint setup and fix lint issues #139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add golangci-lint setup and fix lint issues #139

wants to merge 3 commits into from

Conversation

chenrui333
Copy link
Contributor

followup #137

cc @wlynch

@cpanato
Copy link
Contributor

cpanato commented Jan 6, 2025

cc @wlynch

@wlynch
Copy link
Collaborator

wlynch commented Jan 6, 2025

Thanks! LGTM pending @cpanato's comments.

@chenrui333
Copy link
Contributor Author

addressed the comments 👍

@chenrui333 chenrui333 requested a review from cpanato January 7, 2025 18:34
cpanato
cpanato approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@wlynch wlynch wlynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @cpanato @wlynch