code refactoring, optimalisations, tests, isBech32 func, rename decodeUri to parseUri #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'break' to not check all the prefixes
Basically rewrite the dart_lnurl.dart and hide the handing of non-bech32 lnurls into lnurl.dart for better reading of the code
Adding some tests to verify it handles most of the cases
Add small isBech32() boolean function that tells if the lnurl is bech32 encoded or not (which helps a lot to make code more readable)
Rename the decodeUri to parseUri to make it more clear that it handles both encoded and non encoded lnurls