Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plex changed URLs again #240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Plex changed URLs again #240

wants to merge 2 commits into from

Conversation

pioto
Copy link
Contributor

@pioto pioto commented Sep 11, 2017

Plex changed from https://app.plex.tv/web/ to https://app.plex.tv/desktop, so I'm proposing just matching against anything on app.plex.tv.

Plex changed from https://app.plex.tv/web/ to https://app.plex.tv/desktop, so I'm proposing just matching against anything on app.plex.tv.
@feedbee
Copy link
Collaborator

feedbee commented Sep 16, 2017

Hello, @pioto! Thank you for contribution. Have you get keysocket working with Plex? I tried, but this wasn't successful. Click simulations didn't work. I'm ready to merge your PR, but kindly ask you to answer my question first. Have you tested it?

@pioto
Copy link
Contributor Author

pioto commented Sep 19, 2017

Good question!

No, I had not tried this patch; the UI didn't look substantially different, so I assumed it was just a URL change.

I can confirm it doesn't work, sorry. I'll work on a more complete patch.

This tries to use the aria-labels instead, but still doesn't seem to
work.

I can confirm that it selecting what seems to be the correct <button>
elements, but I'm not seeing the expected results.
@pioto
Copy link
Contributor Author

pioto commented Sep 19, 2017

That patch still doesn't seem to quite do it, so I wonder if it's not listening for events in the same way as before... I'll dive deeper later.

@feedbee
Copy link
Collaborator

feedbee commented Sep 19, 2017

Thank you. I've spent about an hour to find a solution, but it wasn't successful :-(

@feedbee feedbee added this to the 0.9.1 – next bug-fix and new services release milestone Oct 1, 2017
@pioto
Copy link
Contributor Author

pioto commented Oct 4, 2017

Looks like you make some similar changes to what I did in a recent release; unfortunately my Plex server is acting up at the moment... were you able to get things working?

@feedbee feedbee modified the milestones: 0.9.1, 0.9.2 – next bug-fix and new services release Oct 7, 2017
@feedbee feedbee modified the milestones: 0.9.2, 0.9.3 – next bug-fix and new services release Oct 15, 2017
@pioto
Copy link
Contributor Author

pioto commented Oct 15, 2017

I'll try to dive into this deeper this week.

I wonder if they aren't listening to clicks on the button, but may be looking for clicks on some child element or something...

I may also look to see if there's some JS function in their code we can call directly.

@pioto
Copy link
Contributor Author

pioto commented Oct 20, 2017

Made another attempt at this via the JS console the other day, w/o any more success. I tried:

  • sending synthetic KeyboardEvents: looks like they're looking for the deprecated which attribute, and that's read-only. Even if I pass that in the constructor, it ends up with '0' or something like that.
  • playing around with sending clicks to the div, the <i> inside it, etc
  • putting breakpoints all over the place to see how it responds to a "true" click event, or a "space" keyboard event

I also looked a bit to see if there were any objects they exposed in global scope that we could maybe just invoke directly, but had no luck on that front so far.

@feedbee
Copy link
Collaborator

feedbee commented Oct 20, 2017 via email

@feedbee feedbee removed this from the 0.9.3 – next bug-fix and new services release milestone Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants