-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plex changed URLs again #240
base: master
Are you sure you want to change the base?
Conversation
Plex changed from https://app.plex.tv/web/ to https://app.plex.tv/desktop, so I'm proposing just matching against anything on app.plex.tv.
Hello, @pioto! Thank you for contribution. Have you get keysocket working with Plex? I tried, but this wasn't successful. Click simulations didn't work. I'm ready to merge your PR, but kindly ask you to answer my question first. Have you tested it? |
Good question! No, I had not tried this patch; the UI didn't look substantially different, so I assumed it was just a URL change. I can confirm it doesn't work, sorry. I'll work on a more complete patch. |
This tries to use the aria-labels instead, but still doesn't seem to work. I can confirm that it selecting what seems to be the correct <button> elements, but I'm not seeing the expected results.
That patch still doesn't seem to quite do it, so I wonder if it's not listening for events in the same way as before... I'll dive deeper later. |
Thank you. I've spent about an hour to find a solution, but it wasn't successful :-( |
Looks like you make some similar changes to what I did in a recent release; unfortunately my Plex server is acting up at the moment... were you able to get things working? |
I'll try to dive into this deeper this week. I wonder if they aren't listening to clicks on the button, but may be looking for clicks on some child element or something... I may also look to see if there's some JS function in their code we can call directly. |
Made another attempt at this via the JS console the other day, w/o any more success. I tried:
I also looked a bit to see if there were any objects they exposed in global scope that we could maybe just invoke directly, but had no luck on that front so far. |
Consider contacting them. May be they will give us a hint or patch the code
to make click simulation working.
пт, 20 окт. 2017 г. в 22:59, Mike Kelly <[email protected]>:
Made another attempt at this via the JS console the other day, w/o any
more success. I tried:
- sending synthetic KeyboardEvents: looks like they're looking for the
deprecated which
<https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/which>
attribute, and that's read-only. Even if I pass that in the constructor, it
ends up with '0' or something like that.
- playing around with sending clicks to the div, the <i> inside it, etc
- putting breakpoints all over the place to see how it responds to a
"true" click event, or a "space" keyboard event
I also looked a bit to see if there were any objects they exposed in
global scope that we could maybe just invoke directly, but had no luck on
that front so far.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#240 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABr-6aWVX0HvfiqlfGXLqOJmzdwr3y76ks5suPtagaJpZM4PTg_8>
.
--
…---
С уважением, Валера Леонтьев (feedbee).
|
Plex changed from https://app.plex.tv/web/ to https://app.plex.tv/desktop, so I'm proposing just matching against anything on app.plex.tv.