final project v1.0 #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosandk
reviewed
Dec 16, 2022
| chartHeight = 50; | ||
| import fetchJson from '../../utils/fetch-json.js'; | ||
|
|
||
| const BACKEND_URL = process.env.BACKEND_URL; |
There was a problem hiding this comment.
good 👍
лайк за использование переменных окружения
dosandk
reviewed
Dec 16, 2022
| this.chartHeight = 50; | ||
|
|
||
| this.range = range; | ||
| this.url = new URL(url, BACKEND_URL); |
dosandk
reviewed
Dec 16, 2022
src/components/column-chart/index.js
Outdated
| elementLink.href = this.link; | ||
| elementLink.classList.add('column-chart__link'); | ||
| elementLink.textContent = 'View all'; | ||
| this.element.querySelector('.column-chart__title').append(elementLink); |
There was a problem hiding this comment.
было бы неплохо получить ссылку на этот эл-т заранее и не искать его в этом методе
dosandk
reviewed
Dec 16, 2022
| @@ -0,0 +1,198 @@ | |||
| export default class DoubleSlider { | |||
dosandk
reviewed
Dec 16, 2022
src/components/notification/index.js
Outdated
| this.render(); | ||
| } | ||
|
|
||
| static currentElement; |
There was a problem hiding this comment.
лучше располагать данное св-во до констурктора
There was a problem hiding this comment.
вообще все статические св-ва лучше располагать до констурктора
dosandk
reviewed
Dec 16, 2022
| this.element = element.firstElementChild; | ||
| } | ||
|
|
||
| show(element = document.body) { |
dosandk
reviewed
Dec 16, 2022
| @@ -2,9 +2,10 @@ import SortableList from '../sortable-list/index.js'; | |||
| import escapeHtml from '../../utils/escape-html.js'; | |||
| import fetchJson from '../../utils/fetch-json.js'; | |||
|
|
|||
| const IMGUR_CLIENT_ID = process.env.IMGUR_CLIENT_ID; | |||
dosandk
reviewed
Dec 16, 2022
|
|
||
| fileInput.onchange = async () => { | ||
| const [file] = fileInput.files; | ||
| elementInputFile.onchange = async () => { |
There was a problem hiding this comment.
здесь не критично, так как мы уверены что будет только один обработчик события, но на практике лучше всегда использовать метод addEventListener
dosandk
reviewed
Dec 16, 2022
| template() { | ||
| return ` | ||
| <div class="product-form"> | ||
| this.urlCategory = new URL('api/rest/categories', BACKEND_URL); |
There was a problem hiding this comment.
может следует вынести данную логику инициализации url в отдельный метод с целью разгрузить конструктор?
dosandk
reviewed
Dec 16, 2022
| } | ||
| async loadData() { | ||
| const resultCategoryPromise = fetchJson(this.urlCategory); | ||
| const resultProductPromise = this.isNewProduct |
dosandk
reviewed
Dec 16, 2022
| ? parseInt(productForm[field].value) | ||
| : productForm[field].value; | ||
| } | ||
| const [resultCategory, resultProduct] = await Promise.all([resultCategoryPromise, resultProductPromise]); |
There was a problem hiding this comment.
👍 good
лайк за параллельную загрузку независимых данных
dosandk
reviewed
Dec 16, 2022
| if (this.categories) { | ||
| for (const category of this.categories) { | ||
| for (const subCategory of category.subcategories) { | ||
| let newOption = new Option(`${category.title} > ${subCategory.title}`, subCategory.id); |
There was a problem hiding this comment.
👍 good
лайк за использование new Option
dosandk
reviewed
Dec 16, 2022
| const element = productForm.querySelector(`#${item}`); | ||
| wrapper.innerHTML = ` | ||
| <li class="products-edit__imagelist-item sortable-list__item" style=""> | ||
| <input type="hidden" name="url" value="${escapeHtml(url)}"> |
There was a problem hiding this comment.
good 👍
лайк за использование escapeHTML
dosandk
reviewed
Dec 16, 2022
|
|
||
| async loadCategoriesList() { | ||
| return await fetchJson(`${process.env.BACKEND_URL}api/rest/categories?_sort=weight&_refs=subcategory`); | ||
| const sortableListImages = new SortableList({ items }); |
dosandk
reviewed
Dec 16, 2022
| @@ -1,50 +1,48 @@ | |||
| export default class SortableList { | |||
dosandk
reviewed
Dec 16, 2022
|
|
||
| const BACKEND_URL = 'https://course-js.javascript.ru'; | ||
| const BACKEND_URL = process.env.BACKEND_URL; |
dosandk
reviewed
Dec 16, 2022
| this.step = step; | ||
| this.start = start; | ||
| this.end = end; | ||
| this.url = new URL(url, BACKEND_URL); |
dosandk
reviewed
Dec 16, 2022
| sortLocally(id, order) { | ||
| const sortedData = this.sortData(id, order); | ||
| initEventListener() { | ||
| window.addEventListener('scroll', async (event) => { |
dosandk
reviewed
Dec 16, 2022
| if (this.params.id) this.url.searchParams.set('_sort', this.params.id); | ||
| if (this.params.order) this.url.searchParams.set('_order', this.params.order); | ||
|
|
||
| await fetchJson(this.url) |
There was a problem hiding this comment.
не смешивайте await с then
dosandk
reviewed
Dec 16, 2022
| this.renderData(); | ||
| this.isLoading = false; | ||
| }) | ||
| .catch(error => console.error('Something went wrong: ' + error)); |
There was a problem hiding this comment.
здесь обработку ошибки следует делать через try...catch
dosandk
reviewed
Dec 16, 2022
|
|
||
| await fetchJson(this.url) | ||
| .then(data => { | ||
| this.data = this.data.concat(data); |
There was a problem hiding this comment.
this.data = [...this.data, ...data];
dosandk
reviewed
Dec 16, 2022
| } | ||
|
|
||
| destroy() { | ||
| this.remove(); | ||
| this.element = null; | ||
| document.removeEventListener('pointerover', this.onMouseOver); |
dosandk
reviewed
Dec 16, 2022
| components = {}; | ||
| categories; | ||
|
|
||
| constructor() { |
dosandk
reviewed
Dec 16, 2022
src/pages/categories/index.js
Outdated
| } | ||
|
|
||
| onSortableListReordered = async (event) => { | ||
| console.log('got it', event.target); |
There was a problem hiding this comment.
не оставляйте консоли в готовом проекте
dosandk
reviewed
Dec 16, 2022
|
|
||
| this.notificationCategoryOrderedSaved(); | ||
| } catch (error) { | ||
| console.error('something went wrong', error); |
dosandk
reviewed
Dec 16, 2022
| destroy () { | ||
| destroy() { | ||
| this.remove(); | ||
| this.element = null; | ||
| for (const component of Object.values(this.components)) { |
There was a problem hiding this comment.
good 👍
лайк за destroy компонент
dosandk
reviewed
Dec 16, 2022
| destroy() { | ||
| this.remove(); | ||
| this.element = null; | ||
| for (const component of Object.values(this.components)) { |
dosandk
reviewed
Dec 16, 2022
| const rangePicker = new RangePicker(this.range); | ||
|
|
||
| this.sales = { | ||
| url: `api/rest/orders?createdAt_gte=${rangePicker.selected.from.toISOString()}&createdAt_lte=${rangePicker.selected.to.toISOString()}`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.