New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous operator^ with new Eigen versions #1951

Open

mcm001 opened this issue Dec 29, 2024 · 0 comments

Contributor

mcm001 commented Dec 29, 2024 •

edited

Loading

Problem

After bumping the Eigen version we use, I noticed that they also define an operator^ for component-wise bitwise xor. On windows, this results in this compiler output: https://github.com/PhotonVision/thirdparty-gtsam/actions/runs/12537998515/job/34962683956

Resolutions:

For my uses, I can either patch Eigen to remove that operator, or patch GTSAM to remove its operator^ overloads. The code that added them is 10+ years old at this point it looks like (a54d177 4297d24 73fe5b2 ), and some of these might be exposed to downstream users? But the patch set to remove them is super tiny (attached below).
0001-Remove-Matrix-operator.patch
0002-Remove-SubgraphPreconditioner-operator.patch

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment