Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python-related redefinitions for builds using mingw-w64 #141

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix Python-related redefinitions for builds using mingw-w64 #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build/Jamfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ py3-version = [ py-version 3 ] ;

project boost/python
: source-location ../src
: requirements <toolset>gcc <target-os>windows:<cxxflags>-D_hypot=hypot
: requirements <toolset>gcc <target-os>windows <link>shared:<cxxflags>-DMS_WIN64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is doing what you expect. As far as I understand Boost.Build syntax, the last line above defines as requireents:

  • toolset=gcc
  • target-os=windows
  • cxxflags=-DMS_WIN64, whenever link=shared

It looks like what you intend to do is to define -DMS_WIN64 whenever all three features (toolset, target-os, and link) have the given values, yes ?
Please ask on the boost or boost.build mailing list what the right syntax for this is.
(I'm also not sure how this would fix the `"gcc is not a known value..." error. That's another thing to ask on boost.build ML).
Sorry I can't help more with this. Boost.Build is complicated and badly documented, which is one reason why I'm trying to move away from it...

;

rule cond ( test ? : yes * : no * ) { if $(test) { return $(yes) ; } else { return $(no) ; } }
Expand Down