순서 리스팅 버그 수정 #142
Merged
순서 리스팅 버그 수정 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 변경된 검증함수로 구현
YiSoJeong
added
🐛 bug
skid901
approved these changes
Dec 19, 2020
Comment on lines
8
to
27
| export const regex: { [key: string]: RegExp } = { | ||
| heading1: /^#\s[^\s.]*/gm, | ||
| heading2: /^##\s[^\s.]*/gm, | ||
| heading3: /^###\s[^\s.]*/gm, | ||
| bulletedlist: /^[-,+]\s[^\s.]*/gm, | ||
| numberedlist: /^\d.\s[^\s.]*/gm, | ||
| togglelist: /^>\s[^\s.]*/gm, | ||
| quote: /^\|\s[^\s.]*/gm, | ||
| heading1: /^#/gm, | ||
| heading2: /^##/gm, | ||
| heading3: /^###/gm, | ||
| bulletedlist: /^[-,+]/gm, | ||
| numberedlist: /^\d+\./gm, | ||
| togglelist: /^>/gm, | ||
| quote: /^\|/gm, | ||
| }; | ||
|
|
||
| export const validateType = (content: string): BlockType => { | ||
| if (content === '#') return BlockType.HEADING1; | ||
| if (content === '##') return BlockType.HEADING2; | ||
| if (content === '###') return BlockType.HEADING3; | ||
| if (content === '-' || content === '+') return BlockType.BULLETED_LIST; | ||
| if (/^\d+\./gm.test(content)) return BlockType.NUMBERED_LIST; | ||
| if (content === '>') return BlockType.TOGGLE_LIST; | ||
| if (content === '|') return BlockType.QUOTE; | ||
| return null; | ||
| }; |
There was a problem hiding this comment.
regex 와 validateType 내 조건문을 함수로 만들어서 하나의 객체로 만들 수 있을거 같은데,
나중에 고려해 보시면 좋을 것 같아요.
// 예시
const typeValidator = {
[ BlockType.HEADING1 ]: { regex: /^#/gm, validator: content => content === '#' };
};
const validateType = (content: string): BlockType => {
for (const [key, { validator }] of Object.entries(typeValidator)) {
if(validator(content)) return key;
}
return null;
};
domino8788
approved these changes
Dec 19, 2020
| @@ -250,7 +247,7 @@ function BlockContent(blockDTO: Block) { | |||
| listCnt.current = cntOfUpperNumberListBlock() + 1; | |||
| } | |||
| } | |||
| }, [blockDTO.value]); | |||
| }, [blockDTO.type]); | |||
Comment on lines
8
to
27
| export const regex: { [key: string]: RegExp } = { | ||
| heading1: /^#\s[^\s.]*/gm, | ||
| heading2: /^##\s[^\s.]*/gm, | ||
| heading3: /^###\s[^\s.]*/gm, | ||
| bulletedlist: /^[-,+]\s[^\s.]*/gm, | ||
| numberedlist: /^\d.\s[^\s.]*/gm, | ||
| togglelist: /^>\s[^\s.]*/gm, | ||
| quote: /^\|\s[^\s.]*/gm, | ||
| heading1: /^#/gm, | ||
| heading2: /^##/gm, | ||
| heading3: /^###/gm, | ||
| bulletedlist: /^[-,+]/gm, | ||
| numberedlist: /^\d+\./gm, | ||
| togglelist: /^>/gm, | ||
| quote: /^\|/gm, | ||
| }; | ||
|
|
||
| export const validateType = (content: string): BlockType => { | ||
| if (content === '#') return BlockType.HEADING1; | ||
| if (content === '##') return BlockType.HEADING2; | ||
| if (content === '###') return BlockType.HEADING3; | ||
| if (content === '-' || content === '+') return BlockType.BULLETED_LIST; | ||
| if (/^\d+\./gm.test(content)) return BlockType.NUMBERED_LIST; | ||
| if (content === '>') return BlockType.TOGGLE_LIST; | ||
| if (content === '|') return BlockType.QUOTE; | ||
| return null; | ||
| }; |
| } | ||
| return false; | ||
| }; | ||
|
|
||
| const cntOfUpperNumberListBlock = (): number => { | ||
| let cnt = 0; | ||
| if (upperBlocks) { | ||
| for (const upperblock of upperBlocks) { | ||
| if (prevSiblings) { |
There was a problem hiding this comment.
에구.. 제가 실수록 useFamily의 prevSiblings를 reverse 로 저장하게 해놨네요...
죄송합니다 ㅎㅎㅎ;.;
수정 부탁드립니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
순서 리스팅 버그 수정
해당 이슈 📎
#141
변경 사항 🛠
블록 타입 검증함수 교체
테스트 ✨
없음
리뷰어 참고 사항 🙋♀️