버그 수정 및 서버 동기화 로직 적용 #135
Merged
버그 수정 및 서버 동기화 로직 적용 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- blockDTO.value로 변경
- 처음 drag 시 blockHandler가 사라지는 현상 수정 - 서버 동기화 적용
domino8788
added
🐛 bug
skid901
reviewed
Dec 17, 2020
| @@ -287,6 +295,7 @@ function BlockContent(blockDTO: Block) { | |||
| contentEditable | |||
| onKeyDown={handleKeyDown} | |||
| suppressContentEditableWarning | |||
| spellCheck={false} | |||
YiSoJeong
approved these changes
Dec 17, 2020
| ); | ||
| setImmediate(() => { | ||
| setCaretOffset(caretOffset === -1 ? focusOffset : caretOffset); | ||
| setFocus(blockDTO); |
Comment on lines
+42
to
+51
| const getTopAncestor = () => { | ||
| const root = blockMap[page.rootId]; | ||
| const rootChildren = root.childIdList; | ||
| let currentParent = block; | ||
| while (!rootChildren.includes(currentParent.id)) { | ||
| currentParent = blockMap[currentParent.parentId]; | ||
| } | ||
| return currentParent; | ||
| }; | ||
|
|
Comment on lines
+198
to
+200
| (event.key === 'Backspace' && | ||
| !focusOffset && | ||
| focusOffset === anchorOffset) |
| startTransaction(); | ||
| const newBlock = insertNewSibling(updatedBlock); | ||
| const newBlock = await insertNewSibling({ type }, blockIndex + 1); |
There was a problem hiding this comment.
blockIndex + 1 이 디폴트 값 아닌가용?🤔
frontend/src/hooks/useManager.tsx
Outdated
Comment on lines
169
to
190
| const setCaretOffset = ( | ||
| offset: number = window.getSelection().focusOffset, | ||
| isBlur: boolean = true, | ||
| isCaret: boolean = true, | ||
| ) => { | ||
| const sel = window.getSelection(); | ||
| const { focusNode: node } = sel; | ||
| const { length } = node as any; | ||
| !(node instanceof HTMLElement) && | ||
| sel.collapse(node, offset > length ? length : offset); | ||
| const { focusNode: beforeNode } = sel; | ||
| if (isBlur) { | ||
| beforeNode.parentElement.blur(); | ||
| } | ||
| setTimeout(() => { | ||
| const { focusNode: afterNode } = window.getSelection(); | ||
| const length = (afterNode as any).length && afterNode.textContent.length; | ||
| if (length && isCaret) | ||
| sel.collapse(beforeNode, offset > length ? length : offset); | ||
| }); | ||
| // else { | ||
| // const { focusNode: afterNode } = window.getSelection(); | ||
| // const length = (afterNode as any).length && afterNode.textContent.length; | ||
| // if (length) sel.collapse(beforeNode, offset > length ? length : offset); | ||
| // } | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
버그 수정 및 서버 동기화 로직 적용
해당 이슈 📎
#134 #118
변경 사항 🛠
구현내용 요약
테스트 ✨
없음
리뷰어 참고 사항 🙋♀️