Menu 컴포넌트 CSS 수정 #127
Merged
Menu 컴포넌트 CSS 수정 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YiSoJeong
approved these changes
Dec 16, 2020
Comment on lines
-59
to
+65
| <div css={staticHeaderAreaCss(staticMenuToggle)}> | ||
| <AnimatedStaticHeaderArea style={staticAreaStyleProps}> | ||
| <Header /> | ||
| </div> | ||
| <div css={staticScrollAreaCss(staticMenuToggle)}> | ||
| </AnimatedStaticHeaderArea> | ||
| <AnimatedStaticScrollArea style={staticAreaStyleProps}> |
domino8788
approved these changes
Dec 16, 2020
| <DoubleChevronLeft /> | ||
| </HeaderButton> | ||
| )} | ||
| <AnimatedButtons style={buttonStyleProps}> |
There was a problem hiding this comment.
react도 애니메이션 적용이 가능하네요.
커스텀 애니메이션 만들 걱정을 하고있었는데 좋은 참고가 되었습니다. :)
block handler도 애니메이션을 적용했으면 좋겠네요.
| (!hoveredMenuToggle ? <HamburgerMenu /> : <DoubleChevronRight />)} | ||
| {staticMenuToggle || ( | ||
| <div css={buttonWrapper}> | ||
| <AnimatedButton style={hamburgerMenuStyleProps}> |
There was a problem hiding this comment.
참고해서 BlockHandler에 fadein-out 효과를 넣어보도록 하겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu 컴포넌트 CSS 수정
해당 이슈 📎
#124
변경 사항 🛠
테스트 ✨
없음
리뷰어 참고 사항 🙋♀️