impose timeout when running tokenizeLine2() #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2022
evangrayk
reviewed
Nov 11, 2022
| @@ -152,6 +152,8 @@ export class SimpleLanguageInfoProvider { | |||
| } | |||
| } | |||
|
|
|||
| const TOKENIZE_TIMEOUT_MS = 500; | |||
There was a problem hiding this comment.
Could you please add a comment to explain how this is used?
There was a problem hiding this comment.
Good idea: included a link.
|
|
||
| // This is the strategy used by VS Code: | ||
| if (tokenizeLineResult2.stoppedEarly) { | ||
| return {tokens: tokenizeLineResult2.tokens, endState: state}; |
There was a problem hiding this comment.
Should we log when this happens?
DurhamG
reviewed
Nov 14, 2022
| * up the main thread. Note this is used in VS Code: | ||
| * https://github.com/microsoft/vscode/blob/504c5a768a001b2099dd2b44e9dc39e10ccdfb56/src/vs/workbench/services/textMate/common/TMTokenization.ts#L39 | ||
| */ | ||
| const TOKENIZE_TIMEOUT_MS = 500; |
There was a problem hiding this comment.
Good idea: will address in a follow-up diff!
Repository owner
locked as resolved and limited conversation to collaborators
Nov 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with [Sapling]
impose timeout when running tokenizeLine2()