Skip to content

Commit

Permalink
Removes delivery_category field (#292)
Browse files Browse the repository at this point in the history
Removes deprecated delivery_category field on order shipping lines.

Co-authored-by: Tom Hutchinson <[email protected]>
  • Loading branch information
tomhut and Tom Hutchinson authored Jun 5, 2024
1 parent 46c5292 commit 25ac86d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion order.go
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,6 @@ type ShippingLines struct {
Source string `json:"source,omitempty"`
Phone string `json:"phone,omitempty"`
RequestedFulfillmentServiceId string `json:"requested_fulfillment_service_id,omitempty"`
DeliveryCategory string `json:"delivery_category,omitempty"`
CarrierIdentifier string `json:"carrier_identifier,omitempty"`
TaxLines []TaxLine `json:"tax_lines,omitempty"`
Handle string `json:"handle,omitempty"`
Expand Down
5 changes: 0 additions & 5 deletions order_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1266,10 +1266,6 @@ func testShippingLines(t *testing.T, expected, actual ShippingLines) {
t.Errorf("ShippingLines.RequestedFulfillmentServiceId should be (%v), was (%v)", expected.RequestedFulfillmentServiceId, actual.RequestedFulfillmentServiceId)
}

if actual.DeliveryCategory != expected.DeliveryCategory {
t.Errorf("ShippingLines.DeliveryCategory should be (%v), was (%v)", expected.DeliveryCategory, actual.DeliveryCategory)
}

if actual.CarrierIdentifier != expected.CarrierIdentifier {
t.Errorf("ShippingLines.CarrierIdentifier should be (%v), was (%v)", expected.CarrierIdentifier, actual.CarrierIdentifier)
}
Expand Down Expand Up @@ -1449,7 +1445,6 @@ func validShippingLines() ShippingLines {
Source: "canada_post",
Phone: "",
RequestedFulfillmentServiceId: "third_party_fulfillment_service_id",
DeliveryCategory: "",
CarrierIdentifier: "third_party_carrier_identifier",
TaxLines: []TaxLine{
{
Expand Down

0 comments on commit 25ac86d

Please sign in to comment.