Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft orders cart attr test #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions tests/Services/DraftOrderTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<?php

namespace BoldApps\Common\Test\Services\Shopify;

use PHPUnit\Framework\TestCase;
use BoldApps\ShopifyToolkit\Models\Cart\Cart as CartModel;
use BoldApps\ShopifyToolkit\Services\Cart as CartService;
use BoldApps\ShopifyToolkit\Services\DraftOrder as DraftOrderService;
use BoldApps\ShopifyToolkit\Services\Client as ShopifyClient;
use BoldApps\ShopifyToolkit\Services\DraftOrderLineItem as DraftOrderLineItemService;
use BoldApps\ShopifyToolkit\Services\TaxLine as TaxLineService;
use BoldApps\ShopifyToolkit\Services\DraftOrderAppliedDiscount as AppliedDiscountService;

/**
* Class DraftOrderTest.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a total nitpick: could you remove this class comment?

class DraftOrderTest extends TestCase
{
protected function setUp()
{
$mockShopifyClient = $this->createMock(ShopifyClient::class);

$cartService = new CartService($mockShopifyClient);
$this->cart = $cartService->unserializeModel([
'items' => [],
'attributes' => ['cool' => 'yes'],
], CartModel::class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should move lines 24-27 into the test below since it's only relevant to that specific test case.

Then once you've done that, you could add another test for the case of a cart with multiple note attributes to ensure they're being parsed correctly.


$mockDraftOrderLineItemService = $this->createMock(DraftOrderLineItemService::class);
$mockTaxLineService = $this->createMock(TaxLineService::class);
$mockAppliedDiscountService = $this->createMock(AppliedDiscountService::class);

$this->draftOrderService = new DraftOrderService(
$mockShopifyClient,
$mockTaxLineService,
$mockDraftOrderLineItemService,
$mockAppliedDiscountService
);
}

public function testCreateDraftOrderFromCartCarriesOverCartAttributes()
{
$draftOrder = $this->draftOrderService->createDraftOrderFromCart($this->cart);
$result = $draftOrder->getNoteAttributes();
$expected = [['name' => 'cool', 'value' => 'yes']];
$this->assertSame($expected, $result);
}
}