Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CloudFront cache policies #1

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Add support for CloudFront cache policies #1

merged 1 commit into from
Dec 1, 2023

Conversation

bogdanpetrovic0
Copy link
Owner

No description provided.

dejanceltra
dejanceltra approved these changes Dec 1, 2023
View reviewed changes
Copy link

@dejanceltra dejanceltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can you please:
1.) Submit these changes as PR to the upstream?
2.) Build amd64 version of this (I guess with Docker?), and create MAB PR to use it.

@bogdanpetrovic0
Copy link
Owner Author

bogdanpetrovic0 commented Dec 1, 2023 •
edited
Loading

LGTM.

Can you please: 1.) Submit these changes as PR to the upstream? 2.) Build amd64 version of this (I guess with Docker?), and create MAB PR to use it.

Today I stumbled upon this: rebuy-de#1152
So no need to submit them to upstream really, after this is merged we can use the main repo.
2) - Will do.

@bogdanpetrovic0 bogdanpetrovic0 merged commit 57d4b27 into main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dejanceltra dejanceltra dejanceltra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdanpetrovic0 @dejanceltra