Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]account_move_change_currency: fixed rate conversion #55

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

jmo-bmya
Copy link
Contributor

The conversion should always be done with the wizard's currency_rate. The inverse rate is only there for human readability, and could be used in the message, but not in the conversion.
Currently it is not used in the message either.

The conversion should always be done with the wizard's currency_rate.
The inverse rate is only there for human readability, and could be used
in the message, but not in the conversion.
Currently it is not used in the message either.
@jmo-bmya jmo-bmya requested a review from Danisan December 12, 2024 20:53
@jmo-bmya jmo-bmya self-assigned this Dec 12, 2024
@jmo-bmya
Copy link
Contributor Author

@Danisan solicito tu review en este cambio porque el rate que se estaba calculando antes ya no se usa para nada. Podría ir en el mensaje como conversamos, pero eso tú lo quitaste en 6eddd05 ya que querías expresar la tasa siempre en CLP.
Está bien así? O edito el mensaje también?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant