Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hit rate feature #5 #9

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Conversation

kandarppatel28
Copy link
Contributor

Added a new field visitCount to db schema and increment it on each link visit, as mentioned in #5

@vercel
Copy link

vercel bot commented Oct 3, 2020

@kandarppatel28 is attempting to deploy a commit to a Personal Account owned by Bram Musuko Panjaitan on Vercel.

@bmusuko first needs to authorize it.

@bmusuko bmusuko merged commit b64a175 into bmusuko:master Oct 3, 2020
@bmusuko
Copy link
Owner

bmusuko commented Oct 3, 2020

LG

@kandarppatel28
Copy link
Contributor Author

Hay @bmusuko , Its my pleasure to contribute, I request you if you can add "Hactoberfest" into your repo topic, because without it the repo is considered invalid, Thank you in advance. :)

@bmusuko
Copy link
Owner

bmusuko commented Oct 5, 2020

Sorry for the late response, I've added the Hacktoberfest tag. As far as I know, we don't need any tag to be considered valid, as long as we create a pull request to any public repository CMIIW

@kandarppatel28
Copy link
Contributor Author

Thank you @bmusuko , but unfortunately it still shows invalid repo, yes you are right, but they have recently changed their rules and regulations, you can check it out on https://hacktoberfest.digitalocean.com/hacktoberfest-update

@kandarppatel28
Copy link
Contributor Author

I got it, you got a typo there, correct "hactoberfest" to "hacktoberfest", after that you will be good to go

@bmusuko
Copy link
Owner

bmusuko commented Oct 5, 2020

I'm so sorry, I just copy your tag earlier lol. I've changed the label to hacktoberfest, can you confirm your PR already valid? @kandarppatel28

@kandarppatel28
Copy link
Contributor Author

Oh, that's my bad, yes @bmusuko no the PR is valid! Thank you! Happy Hacking!!!
Any thoughts regarding the implementation of the dashboard, for displaying visit count?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants